etr2460 commented on a change in pull request #8398: [SIP-15] Adding initial
framework
URL:
https://github.com/apache/incubator-superset/pull/8398#discussion_r335723747
##########
File path: superset/config.py
##########
@@ -695,3 +695,9 @@ class CeleryConfig(object):
except Exception:
logging.exception("Found but failed to import local superset_config")
raise
+
+
+# Note currently SIP-15 feature is WIP and should not be enabled.
+SIP_15_ENABLED = False
+SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["unknown", "inclusive"]
+SIP_15_TOAST_MESSAGE = 'Preview then save your chart using the new time range
endpoints <a href="{url}" class="alert-link">here</a>.'
Review comment:
Maybe prefixing this with `Action Required:` or something like that to make
it more apparent what's needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
