etr2460 commented on a change in pull request #8398: [SIP-15] Adding initial
framework
URL:
https://github.com/apache/incubator-superset/pull/8398#discussion_r339704538
##########
File path: superset/config.py
##########
@@ -705,3 +705,9 @@ class CeleryConfig(object):
except Exception:
logging.exception("Found but failed to import local superset_config")
raise
+
+
+# Note currently SIP-15 feature is WIP and should not be enabled.
+SIP_15_ENABLED = False
Review comment:
i think this should all be above line 682, otherwise you'll be overriding
custom configs here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
