durgaprasadml opened a new pull request, #41772: URL: https://github.com/apache/superset/pull/41772
Fixes #41747 <!-- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR fixes an issue where the **"Search by"** dropdown was displayed in Table charts whenever **Server Pagination** was enabled, even when the **Search Box** option was disabled in the Customize tab. Previously, enabling server-side pagination implicitly caused search-related controls to appear, resulting in confusing behavior for users who intentionally disabled search functionality. This change updates the rendering logic so that search-related UI elements are only displayed when search functionality is explicitly enabled. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before - Server Pagination enabled - Search Box disabled - "Search by" dropdown was still visible #### After - Server Pagination enabled - Search Box disabled - "Search by" dropdown is hidden - Search controls only appear when Search Box is enabled ### TESTING INSTRUCTIONS 1. Create a Table chart with one or more text columns. 2. Enable **Server Pagination**. 3. Leave **Search Box** disabled under the Customize tab. 4. Save and open the chart. 5. Verify that the **"Search by"** dropdown is not displayed. Verify the following scenarios: #### Case 1 - Server Pagination = Disabled - Search Box = Disabled Expected: - No search input - No search dropdown #### Case 2 - Server Pagination = Disabled - Search Box = Enabled Expected: - Search input visible - Search dropdown visible #### Case 3 - Server Pagination = Enabled - Search Box = Disabled Expected: - No search input - No search dropdown #### Case 4 - Server Pagination = Enabled - Search Box = Enabled Expected: - Search input visible - Search dropdown visible ### ADDITIONAL INFORMATION - Added regression coverage for search control visibility. - Preserves existing server-side pagination functionality. - Preserves existing search behavior when Search Box is enabled. - No API changes. - No database migrations required. - Backward compatible with existing saved charts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
