bito-code-review[bot] commented on PR #41772:
URL: https://github.com/apache/superset/pull/41772#issuecomment-4883362604
<!-- Bito Reply -->
The review suggestion is correct. Introducing a `describe()` block for only
three test cases is unnecessary and violates the practice of keeping test
suites flat when standalone `test()` cases suffice. You can resolve this by
removing the `describe` wrapper and promoting the `it` blocks to top-level
tests within the existing `describe('plugin-chart-table', ...)` block.
There are no other comments on this PR to address.
**superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx**
```
it('does not render "Search by" if include_search is false (server
pagination enabled)', () => {
// ... test implementation
});
it('does not render "Search by" if there are no search options (server
pagination enabled)', () => {
// ... test implementation
});
it('renders "Search by" if include_search is true and there are search
options (server pagination enabled)', () => {
// ... test implementation
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
