rusackas commented on PR #38522:
URL: https://github.com/apache/superset/pull/38522#issuecomment-4883692368
@yousoph the core fix here is right... I traced it on master:
`calculateTotals` keyed by `getColumnLabel(groupby)` while the rows are keyed
by `colnames`, so any divergence (array groupby especially) NaN'd the
percentages. Keying by `colnames` puts totals and lookups in one namespace, and
test 4 pins it properly. That also answers @msyavuz's regression question, I
believe: the tooltip lookup keys are built from `colnames` already, so the
totals change can't drift from them.
A few things before we can merge though. Joe's `toContain('2')` assertion
note and the `metric: 'revenue'` fixture mismatch (flagged by three reviewers)
are still unaddressed. The `xKey`/`yKey` cast hunk is a runtime no-op with
misleading "Convert" comments, per @msyavuz... I'd just drop that hunk and keep
the `calculateTotals` change. And the PR description still says test-only while
shipping a prod fix.
I've resolved the noise/duplicate bot threads above and left the two real
ones open. Happy to re-review after those... holler if you want a hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
