yousoph commented on PR #38522:
URL: https://github.com/apache/superset/pull/38522#issuecomment-4907302346
Re-pointed this onto my own fork so the review fixes could be pushed
directly — continued in #41864, which carries all four requested fixes from
@rusackas's list (dropped the no-op `xKey`/`yKey` cast, fixed the numeric-axis
test `metric`, replaced Joe's `toContain('2')`, and tightened the loose
percentage assertions). Closing this one in favor of #41864 — thanks for the
reviews @rusackas @msyavuz @sadpandajoe!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
