rusackas commented on PR #36144: URL: https://github.com/apache/superset/pull/36144#issuecomment-4883692560
@yousoph checking in on this draft since it's been parked a while... the `echarts_pie` → `pie` rename is a real correction worth landing (matches `VizType.Pie`), but a few things need attention before it comes out of draft. The move of `echartsOptionsOverrides` inside `"token"` cuts against the code's intended API... `Theme.tsx` extracts those as top-level config properties, and the token placement only works incidentally via the spread. I'd keep them top-level unless the theming folks say otherwise. The three bot threads above are all real (a `"True"` string where a Python boolean should be, and two examples with unbalanced braces), and the chart-type list still documents `echarts_bubble`/`echarts_funnel`/`echarts_gauge` where the real viz types are `bubble_v2`/`funnel`/`gauge_chart`. Do you plan to carry this forward? Happy to help get it over the line, or we can adopt the `pie` fix on a small fresh PR if you'd rather. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
