rusackas commented on code in PR #36144:
URL: https://github.com/apache/superset/pull/36144#discussion_r3523802666
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -215,38 +214,45 @@ Target specific chart types using
`echartsOptionsOverridesByChartType`:
THEME_DEFAULT = {
"token": {
"colorPrimary": "#2893B3",
- # ... other tokens
- },
- "echartsOptionsOverridesByChartType": {
- "echarts_pie": {
+ "echartsOptionsOverridesByChartType": {
+ "pie": {
+ "tooltip": {
+ "backgroundColor": "rgba(0, 0, 0, 0.8)",
+ "borderColor": "#ccc",
+ "textStyle": {
+ "color": "#fff"
+ }
+ },
"legend": {
- "orient": "vertical",
- "right": 10,
- "top": "center"
+ "orient": "vertical",
+ "right": 10,
+ "top": "center"
}
- },
- "echarts_timeseries": {
+ },
+ "echarts_timeseries": {
"xAxis": {
- "axisLabel": {
- "rotate": 45,
- "fontSize": 12
- }
+ "axisLabel": {
+ "rotate": 45,
+ "fontSize": 12
+ }
},
- "dataZoom": [{
+ "dataZoom": [
+ {
"type": "slider",
- "show": True,
+ "show": "True",
Review Comment:
This one's right... the reformat turned the Python boolean `True` into the
string `"True"`, which would silently break the dataZoom override.
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -213,32 +213,31 @@ Apply settings to all ECharts visualizations using
`echartsOptionsOverrides`:
```python
THEME_DEFAULT = {
- "token": {
- "colorPrimary": "#2893B3",
- # ... other Ant Design tokens
- },
+ "token": {
+ "colorPrimary": "#2893B3",
+ # ... other Ant Design tokens
"echartsOptionsOverrides": {
- "grid": {
- "left": "10%",
- "right": "10%",
- "top": "15%",
- "bottom": "15%"
- },
- "tooltip": {
- "backgroundColor": "rgba(0, 0, 0, 0.8)",
- "borderColor": "#ccc",
- "textStyle": {
- "color": "#fff"
- }
- },
- "legend": {
- "textStyle": {
- "fontSize": 14,
- "fontWeight": "bold"
- }
+ "grid": {
+ "left": "10%",
+ "right": "10%",
+ "top": "15%",
+ "bottom": "15%"
+ },
+ "tooltip": {
+ "backgroundColor": "rgba(0, 0, 0, 0.8)",
+ "borderColor": "#ccc",
+ "textStyle": {
+ "color": "#fff"
+ }
+ },
+ "legend": {
+ "textStyle": {
+ "fontSize": 14,
+ "fontWeight": "bold"
}
+ }
}
-}
+ }
```
Review Comment:
Confirmed, the snippet ends one `}` short after the reshuffle... all three
examples need a brace-balance pass.
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -249,38 +248,45 @@ Target specific chart types using
`echartsOptionsOverridesByChartType`:
THEME_DEFAULT = {
"token": {
"colorPrimary": "#2893B3",
- # ... other tokens
- },
- "echartsOptionsOverridesByChartType": {
- "echarts_pie": {
+ "echartsOptionsOverridesByChartType": {
+ "pie": {
+ "tooltip": {
+ "backgroundColor": "rgba(0, 0, 0, 0.8)",
+ "borderColor": "#ccc",
+ "textStyle": {
+ "color": "#fff"
+ }
+ },
"legend": {
- "orient": "vertical",
- "right": 10,
- "top": "center"
+ "orient": "vertical",
+ "right": 10,
+ "top": "center"
}
- },
- "echarts_timeseries": {
+ },
+ "echarts_timeseries": {
"xAxis": {
- "axisLabel": {
- "rotate": 45,
- "fontSize": 12
- }
+ "axisLabel": {
+ "rotate": 45,
+ "fontSize": 12
+ }
},
- "dataZoom": [{
+ "dataZoom": [
+ {
"type": "slider",
- "show": True,
+ "show": "True",
"start": 0,
"end": 100
- }]
- },
- "echarts_bubble": {
+ }
+ ]
+ },
+ "echarts_bubble": {
"grid": {
- "left": "15%",
- "bottom": "20%"
+ "left": "15%",
+ "bottom": "20%"
}
+ }
}
- }
-}
+ }
```
Review Comment:
Same as the global-overrides thread... second example has the same
unbalanced braces.
##########
docs/admin_docs/configuration/theming.mdx:
##########
@@ -249,38 +248,45 @@ Target specific chart types using
`echartsOptionsOverridesByChartType`:
THEME_DEFAULT = {
"token": {
"colorPrimary": "#2893B3",
- # ... other tokens
- },
- "echartsOptionsOverridesByChartType": {
- "echarts_pie": {
+ "echartsOptionsOverridesByChartType": {
+ "pie": {
+ "tooltip": {
+ "backgroundColor": "rgba(0, 0, 0, 0.8)",
+ "borderColor": "#ccc",
+ "textStyle": {
+ "color": "#fff"
+ }
+ },
"legend": {
- "orient": "vertical",
- "right": 10,
- "top": "center"
+ "orient": "vertical",
+ "right": 10,
+ "top": "center"
}
- },
- "echarts_timeseries": {
+ },
+ "echarts_timeseries": {
"xAxis": {
- "axisLabel": {
- "rotate": 45,
- "fontSize": 12
- }
+ "axisLabel": {
+ "rotate": 45,
+ "fontSize": 12
+ }
},
- "dataZoom": [{
+ "dataZoom": [
+ {
"type": "slider",
- "show": True,
+ "show": "True",
Review Comment:
Duplicate of the bito thread above on the same `"True"` string... tracking
it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
