rusackas commented on issue #41779: URL: https://github.com/apache/superset/issues/41779#issuecomment-4887679802
For the record, some concrete follow-up work if this passes the vote — places in the current codebase that are already living with the hardcoded-fallback shape this SIP replaces: - [ ] **`editors`** — `EditorHost` falls back to a hardcoded `AceEditorProvider` (`src/core/editors/EditorHost.tsx`). Ace would become the registered default provider per language, `getEditor()` starts telling the truth about what's rendering, and an extension could wrap the default editor (add a toolbar, decorations) instead of having to reimplement one from scratch. - [ ] **`chat`** — no built-in exists, so the migration is just adopting the registry shape with an empty default tier for uniform semantics. If we ever ship a built-in assistant, it lands as the default provider with zero API change. - [ ] **SQL Lab South Pane panels** — the built-in Results and Query History tabs are hardcoded in `SouthPane` while extension views get appended from the `sqllab.panels` views registry. Registering the built-ins as default views in that same registry would open up reordering/replacing/augmenting them... probably the most interesting of the three, and the most work. - [ ] **Docs** — promote the pattern from the dashboards extension-point page to the extensions architecture doc as the standard for replace-the-default contribution points. The dashboard renderer (#41703) is the reference implementation and is on hold:sip! pending this vote. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
