EnxDev commented on issue #41779: URL: https://github.com/apache/superset/issues/41779#issuecomment-4923884195
I agree with @michael-s-molina that dashboard-specific concerns should stay in the Dashboard Extensions SIP, while this proposal focuses on the generic provider infrastructure. One question I had while reading this proposal is whether it's worth clarifying the boundary between provider resolution and provider instantiation. The resolution model (override ?? default) feels generic and reusable across provider-based contribution points, but the lifecycle of the resolved provider seems to depend on the semantics of the contribution point itself. For example: - Chat is naturally a singleton (one instance per application). - A dashboard builder is a singleton for the active dashboard. - Editors can have multiple concurrent instances (one per SQL tab). - Chart-level contributions are scoped per chart. That makes me think this SIP could standardize how providers are resolved, while leaving when and how many instances are created to each contribution point. That would allow surface-specific SIPs to define their own lifecycle semantics while still sharing a common provider model. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
