codeant-ai-for-open-source[bot] commented on code in PR #41780:
URL: https://github.com/apache/superset/pull/41780#discussion_r3526543549
##########
superset/views/base.py:
##########
@@ -578,25 +578,50 @@ def common_bootstrap_payload() -> dict[str, Any]:
# Convert locale to string for proper cache key hashing
locale_str = str(locale) if locale else None
payload = dict(cached_common_bootstrap_data(utils.get_user_id(),
locale_str))
- # Inject the Jed language pack outside the per-user memoize so the cached
- # payload stays small and the pack is shared across users for the same
- # locale. The frontend uses it to configure the translator synchronously,
- # before any code-split chunk evaluates a module-level `const X = t('...')`
- # (upstream issue #35330).
- language = payload.get("locale")
- if language and language != "en":
- # Respect a pack already provided via COMMON_BOOTSTRAP_OVERRIDES_FUNC
- # (the workaround in #35330 does exactly that), otherwise load the
- # shared one. `get_language_pack` returns the empty English pack on a
- # miss, which is the right result (English) when no translation file
- # exists.
- pack = payload.get("language_pack") or get_language_pack(language)
- else:
- pack = None
- payload["language_pack"] = pack
+ # The language pack itself is NOT embedded in the payload: spa.html loads
+ # it through the content-addressed
/language_pack/<lang>/<version>/script.js
+ # tag before the entry bundle, keeping HTML small while still configuring
+ # the translator synchronously (upstream issue #35330). A pack provided via
+ # COMMON_BOOTSTRAP_OVERRIDES_FUNC (the historical workaround) is respected
+ # and takes precedence over the script tag.
+ payload.setdefault("language_pack", None)
return payload
+def get_language_pack_template_context(common: dict[str, Any]) -> dict[str,
Any]:
+ """Template vars controlling how spa.html delivers the language pack.
+
+ ``common`` is the already-built common bootstrap payload for the request
+ (passed in rather than re-derived, so callers that assembled or mocked
+ their own payload stay consistent with what the template sees).
+
+ Three mutually exclusive outcomes:
+ - English (or no locale): no script tag, nothing to stash.
+ - Operator supplied a pack via COMMON_BOOTSTRAP_OVERRIDES_FUNC: no script
+ tag; spa.html stashes the bootstrap pack on window instead.
+ - Otherwise: emit the content-addressed script URL so the browser can
+ cache the pack as immutable and cache-bust on translation changes.
+ """
+ language = common.get("locale")
+ if not language or language == "en":
+ return {"language_pack_src": None, "language_pack_inline": False}
+ if common.get("language_pack"):
+ return {"language_pack_src": None, "language_pack_inline": True}
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag truthiness checks for `language_pack` in
`superset/views/base.py`; an empty `{}` override is intentionally treated as
absent, and only non-empty packs are valid overrides.
**Applied to:**
- `superset/views/base.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
