abderbejaoui commented on code in PR #38490:
URL: https://github.com/apache/superset/pull/38490#discussion_r3531239885
##########
superset-frontend/src/features/databases/DatabaseModal/index.tsx:
##########
@@ -343,13 +343,14 @@ export function dbReducer(
action.payload.name === 'schema_cache_timeout' ||
action.payload.name === 'table_cache_timeout'
) {
+ const timeoutValue = Math.max(0, Number(action.payload.value) || 0);
Review Comment:
Fixed in 19a8c26 per @rusackas's suggestion — empty string now maps to NaN
before coercion and falls through to undefined, clearing back to the global
default. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
