mikebridge commented on PR #40221: URL: https://github.com/apache/superset/pull/40221#issuecomment-4897979881
Triage of the seven open bot threads on this PR (verified where load-bearing, via Claude): 1. **`query_object.py` — codeant "Architect HIGH" on `force_query` in the cache key: VERIFIED REAL** and fixed in **#41825** (into this branch). A forced refresh was writing its fresh result under a different cache key while ordinary requests kept serving the stale entry — affects every chart on the legacy path, not just semantic layers. One-line fix + regression test. 2. **`TooltipContent.test.tsx` — bito's `data-testid` mismatch: FALSE POSITIVE.** The repo's single jest config covers `packages/` (testRegex) and loads `spec/helpers/setup.ts`, which sets `testIdAttribute: 'data-test'` — so `getByTestId` matches `data-test` attributes correctly. Safe to resolve. 3. **`cache.py` broad-except suggestions (bito)**: the blanket catches are the file's deliberate defensive pattern (housekeeping must never fail a request) and carry pragma annotations; also reviewed as intentional in the #41824 review rounds. Safe to resolve as by-design. 4. **Select.tsx ×2 (counts concatenated outside `t()`) and the JSON Forms `placeholderText` translation**: legitimate minor i18n nits — worth a small cleanup commit but not blocking. 5. **`TooltipContent.tsx` duplication (two near-identical `cacheSource` conditionals)**: fair nit, one small helper. Separately: **#41824** (also into this branch) fixes the twice-flagged `store_result` index race, hardened through three review rounds + live-Redis validation — details in that PR's comment thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
