mikebridge commented on code in PR #40221:
URL: https://github.com/apache/superset/pull/40221#discussion_r3532281674


##########
superset/common/query_object.py:
##########
@@ -128,6 +129,7 @@ def __init__(  # pylint: disable=too-many-locals, 
too-many-arguments
         post_processing: list[dict[str, Any] | None] | None = None,
         row_limit: int | None = None,
         row_offset: int | None = None,
+        force_query: bool = False,
         series_columns: list[Column] | None = None,

Review Comment:
   Verified real — `cache_key()` strips `from_dttm`/`to_dttm` but not 
`force_query`, so a forced refresh writes under a different key while ordinary 
requests keep reading the stale entry; affects every chart on the legacy path. 
Fix (one line + a key-equality regression test, validated to fail without it) 
opened into this branch as **#41825**.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to