mikebridge opened a new pull request, #41826:
URL: https://github.com/apache/superset/pull/41826

   ### SUMMARY
   
   Third contribution **into #40221's branch** (`sl-cache`) — the remaining 
half of the force-refresh bug shape fixed in #41825:
   
   `_make_cached_dispatch` returned the raw dispatcher when `force_query` was 
set, bypassing both the cache read **and `store_result`**. Consequence: a 
forced refresh executed fresh but **never replaced the stale containment-cache 
entry** — other requests whose queries were contained by that stale entry kept 
being served from it until TTL or a view-definition change. (#41825 fixed the 
same shape at the DATA-cache layer; this fixes it at the semantic layer.)
   
   **The fix**: forced queries skip only the cache *read* and still store their 
fresh result; row-count queries continue to bypass entirely.
   
   ### TESTING INSTRUCTIONS
   
   The existing force test is rewritten to pin the full contract: the forced 
query re-executes, **and** a subsequent ordinary request is served from cache 
with the *refreshed* value rather than the stale one — validated to **fail 
against the pre-fix mapper**.
   
   ```bash
   pytest tests/unit_tests/semantic_layers/cache_integration_test.py -q   # 15 
passed
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to