mikebridge commented on PR #41826: URL: https://github.com/apache/superset/pull/41826#issuecomment-4898567541
Round-2 review (four-lens panel via Claude, findings verified): **4/4 approve, 0 blockers**. Resolutions pushed: - **The shadowing gap is real and now fixed — in #41824**, which owns the `cache.py` changes: candidates were ranked by reuse mode only, and stable sort's insertion-order tie-breaking let an *older stale broader* entry be served ahead of a just-forced fresh entry for the identical query. `e82bce3cd9` adds freshest-first tie-breaking with a deterministic regression test (fails under the rank-only sort). Placing it there preserves the verified property that all three sibling PRs merge cleanly in any order (`git merge-tree` checked). - **Docstrings scoped honestly** (`6675fe294e` here): a forced store replaces the entry for the *same canonical shape*; broader stale entries are out of a narrower result's reach by design and age out by TTL — with freshest-first ranking making the refreshed entry win for the identical query. Test's mock-swap counter-reset subtlety documented. Panel also verified: forced stores are shape-safe (the stored entry is exactly what a cold miss would write), the payload overwrite survives #41824's lock-skip path (the `set(vkey)` precedes lock acquisition), and all four candidate mutants of the rewritten test are killed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
