codecov[bot] commented on PR #41843: URL: https://github.com/apache/superset/pull/41843#issuecomment-4899723025
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41843?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `67.39130%` with `15 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 63.98%. Comparing base ([`1c3b070`](https://app.codecov.io/gh/apache/superset/commit/1c3b070d342df2bf4f005f0713fee8b0d249db04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`604235b`](https://app.codecov.io/gh/apache/superset/commit/604235b86cc889cc035dad617498ac3fc359b643?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/41843?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/41843?src=pr&el=tree&filepath=superset%2Fsecurity%2Fmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | 44.44% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/41843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...orMessage/DatasourceSecurityAccessErrorMessage.tsx](https://app.codecov.io/gh/apache/superset/pull/41843?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fcomponents%2FErrorMessage%2FDatasourceSecurityAccessErrorMessage.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFzb3VyY2VTZWN1cml0eUFjY2Vzc0Vycm9yTWVzc2FnZS50c3g=) | 88.46% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset-frontend/src/setup/setupErrorMessages.ts](https://app.codecov.io/gh/apache/superset/pull/41843?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fsetup%2FsetupErrorMessages.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlcy50cw==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/41843?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #41843 +/- ## ========================================== - Coverage 64.77% 63.98% -0.80% ========================================== Files 2689 2690 +1 Lines 148945 148987 +42 Branches 34369 34390 +21 ========================================== - Hits 96486 95324 -1162 - Misses 50693 51905 +1212 + Partials 1766 1758 -8 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.19% <38.88%> (-0.01%)` | :arrow_down: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.66% <82.14%> (-0.01%)` | :arrow_down: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.73% <38.88%> (-0.01%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.65% <44.44%> (-1.67%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.50% <44.44%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/apache/superset/pull/41843/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41843?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
