codeant-ai-for-open-source[bot] commented on code in PR #41843:
URL: https://github.com/apache/superset/pull/41843#discussion_r3541072943
##########
superset/security/manager.py:
##########
@@ -123,6 +124,42 @@ def get_conf() -> Any:
return current_app.config
+def _render_permission_instructions_link(
+ *,
+ datasource_id: str = "",
+ datasource_name: str = "",
+ table_names: str = "",
+) -> Optional[str]:
+ """Render the configured ``PERMISSION_INSTRUCTIONS_LINK``.
+
+ The configured URL may contain ``{datasource_id}``, ``{datasource_name}``,
+ ``{table_names}`` and ``{username}`` placeholders, which are substituted
with
+ URL-encoded values so the link can deep-link into an organization's access
+ request system. A URL with no placeholders is returned unchanged, and an
+ empty/unset config returns ``None`` (no link). Unsupplied placeholders are
+ replaced with an empty string.
+ """
+ link = get_conf().get("PERMISSION_INSTRUCTIONS_LINK")
Review Comment:
**Suggestion:** Add an explicit type annotation for this local variable to
satisfy the type-hinting rule for relevant new variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is newly added Python code and `link` is a local variable with a clear
type (`Optional[str]`) that is not annotated, so it matches the type-hint rule.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1adc651cbd5e4da9b5ca822b4631990d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1adc651cbd5e4da9b5ca822b4631990d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/security/manager.py
**Line:** 142:142
**Comment:**
*Custom Rule: Add an explicit type annotation for this local variable
to satisfy the type-hinting rule for relevant new variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41843&comment_hash=1c2ba729b41cb6b90368c621e92ce95061db3fd0e476320750255e53b5ace08d&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41843&comment_hash=1c2ba729b41cb6b90368c621e92ce95061db3fd0e476320750255e53b5ace08d&reaction=dislike'>👎</a>
##########
superset/security/manager.py:
##########
@@ -123,6 +124,42 @@ def get_conf() -> Any:
return current_app.config
+def _render_permission_instructions_link(
+ *,
+ datasource_id: str = "",
+ datasource_name: str = "",
+ table_names: str = "",
+) -> Optional[str]:
+ """Render the configured ``PERMISSION_INSTRUCTIONS_LINK``.
+
+ The configured URL may contain ``{datasource_id}``, ``{datasource_name}``,
+ ``{table_names}`` and ``{username}`` placeholders, which are substituted
with
+ URL-encoded values so the link can deep-link into an organization's access
+ request system. A URL with no placeholders is returned unchanged, and an
+ empty/unset config returns ``None`` (no link). Unsupplied placeholders are
+ replaced with an empty string.
+ """
+ link = get_conf().get("PERMISSION_INSTRUCTIONS_LINK")
+ if not link:
+ return None
+
+ username = ""
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
local variable. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is new Python code and `username` is a local variable initialized to an
empty string, so it can be annotated as `str`; the omission satisfies the
type-hinting rule violation.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=72b9d69877d04849a5a5c57e9428493b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=72b9d69877d04849a5a5c57e9428493b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/security/manager.py
**Line:** 146:146
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
local variable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41843&comment_hash=05e3183f8b5b6850b28262b4cf03d7d315cb46c7b61ef6c19c4054038ae4db7b&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41843&comment_hash=05e3183f8b5b6850b28262b4cf03d7d315cb46c7b61ef6c19c4054038ae4db7b&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
