EnxDev commented on code in PR #38831:
URL: https://github.com/apache/superset/pull/38831#discussion_r3537842749
##########
superset-frontend/src/features/reports/ReportModal/index.tsx:
##########
@@ -196,12 +196,12 @@ function ReportModal({
setCurrentReport({ isSubmitting: true, error: undefined });
try {
if (isEditMode && currentReport.id) {
- // Edit path: include all fields, PUT endpoint accepts
recipients/owners directly
+ // Edit path: include all fields, PUT endpoint accepts
recipients/editors directly
await dispatch(
editReport(currentReport.id, {
...commonFields,
creation_method: creationMethod,
- owners: [userId],
+ editors: [userId],
Review Comment:
Would make sense to use the user's subject id as done in AlertReportModal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
