bito-code-review[bot] commented on code in PR #41859:
URL: https://github.com/apache/superset/pull/41859#discussion_r3538450503
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -930,19 +930,14 @@ export function getAxisType(
stack: StackType,
forceCategorical?: boolean,
dataType?: GenericDataType,
- seriesType?: EchartsTimeseriesSeriesType,
): AxisType {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Behavioral change: bar charts axis type</b></div>
<div id="fix">
Removing the unused `seriesType` parameter simplifies the function but
changes observable behavior: bar charts with numeric x-axis data and
`stack=false` now render on a Value axis instead of Category axis. Verify this
behavioral shift is intentional and document it, or restore the `seriesType`
check to preserve the original category-axis rendering for bar charts.
</div>
</div>
<small><i>Code Review Run #0a67ce</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
