bito-code-review[bot] commented on code in PR #41859:
URL: https://github.com/apache/superset/pull/41859#discussion_r3542283085
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -930,19 +930,14 @@ export function getAxisType(
stack: StackType,
forceCategorical?: boolean,
dataType?: GenericDataType,
- seriesType?: EchartsTimeseriesSeriesType,
): AxisType {
Review Comment:
<!-- Bito Reply -->
The suggestion is valid. Removing the `seriesType` parameter does simplify
the function, but as noted, it changes the axis type rendering for bar charts
with numeric x-axis data. If this behavioral change is intentional, it should
be documented; otherwise, the `seriesType` check should be retained to maintain
existing rendering logic.
**superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts**
```
export function getAxisType(
stack: StackType,
forceCategorical?: boolean,
dataType?: GenericDataType,
): AxisType {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
