yousoph commented on code in PR #38535:
URL: https://github.com/apache/superset/pull/38535#discussion_r3539866287
##########
superset-frontend/src/utils/downloadAsImage.tsx:
##########
@@ -25,6 +25,8 @@ import { addWarningToast } from
'src/components/MessageToasts/actions';
import type { AgGridContainerElement } from '@superset-ui/core/components';
const IMAGE_DOWNLOAD_QUALITY = 0.95;
+const PNG_SCALE = 2; // Higher quality for PNG
+export type BackgroundType = 'transparent' | 'solid';
const TRANSPARENT_RGBA = 'transparent';
Review Comment:
Good catch — this was the `lint-frontend` failure (`TS6133`). It came from
the master merge accidentally dropping the `|| color === TRANSPARENT_RGBA`
clause. Fixed in 9c67fad by restoring master's exact condition rather than
deleting the constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
