bito-code-review[bot] commented on code in PR #38535:
URL: https://github.com/apache/superset/pull/38535#discussion_r3539866947
##########
superset-frontend/src/utils/downloadAsImage.tsx:
##########
@@ -25,6 +25,8 @@ import { addWarningToast } from
'src/components/MessageToasts/actions';
import type { AgGridContainerElement } from '@superset-ui/core/components';
const IMAGE_DOWNLOAD_QUALITY = 0.95;
+const PNG_SCALE = 2; // Higher quality for PNG
+export type BackgroundType = 'transparent' | 'solid';
const TRANSPARENT_RGBA = 'transparent';
Review Comment:
<!-- Bito Reply -->
Bito's suggestions are intended to help identify potential issues like dead
code, which can improve maintainability. Whether to avoid such suggestions
depends on your team's preference for strict code cleanliness versus minimizing
noise in reviews. You can manage these rules via the provided link if you wish
to adjust the sensitivity or types of suggestions Bito provides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]