yousoph commented on PR #41637: URL: https://github.com/apache/superset/pull/41637#issuecomment-4909494437
Thanks for the thorough review @rusackas — both blockers were spot on and are fixed in `7491d3c`: **1. Failing `DndColumnMetricSelect` test** — updated the expectation to the `arrayMove` result `['metric_a', 'column_b', 'column_a']` and rewrote the stale "swap" comment. **2. `DndFilterSelect` (the standard `adhoc_filters` control)** — you're right, I'd only fixed the legacy `AdhocFilterControl`. Its `onShiftOptions` now does `arrayMove` + `setValues` + `onChange(newValues)` so the reorder actually persists. Verified live in a running Explore: - Before: `[is_software_dev, school_degree, job_pref, time_start]` - After dragging filter 0 → position 2: `[school_degree, job_pref, is_software_dev, time_start]` - The `PUT /api/v1/explore/form_data` payload carried the new `adhoc_filters` order, and it persisted across a full page reload. (As you'd expect, `adhoc_filters` is a query control rather than a `renderTrigger`, so the PUT fires when the query runs — the bug was purely that `onChange` was never called, so the run used the stale order.) **Non-blocking follow-up (included):** folded in the `arrayMove` fix for `DndColumnSelect` (via `OptionSelector.move` replacing the adjacent `swap`) and `ContourControl.onShiftContour` — they persisted already, but the swap was wrong for non-adjacent drags. All affected suites stay green (`DndColumnMetricSelect`, `DndFilterSelect`, `DndColumnSelect`, `ExploreDndContext` — 52 tests pass). **Left for a separate issue:** legacy `MetricsControl` reorder (broken before and after this PR), per your note. Happy to file that follow-up. Ready for re-review 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
