yousoph commented on PR #41637: URL: https://github.com/apache/superset/pull/41637#issuecomment-4930324838
Follow-up commit `3335256c6e`: calm the pill **reorder** animation. Reordering pills within a control (metrics / dimensions / adhoc filters) was playing @dnd-kit's default FLIP layout animation on drop, which reads as a springy "bounce" that makes it hard to see what actually moved. Two small changes on the pill sortables (`OptionControls` + `OptionWrapper`): - `animateLayoutChanges: () => false` — drop the FLIP settle so pills settle without the bounce. - `CSS.Transform.toString` → `CSS.Translate.toString` — translate only (no `scaleX/scaleY`), so variable-width pills don't morph into their neighbor's size mid-reorder. Verified live in a browser (jsdom can't drive @dnd-kit pointer sensors): reorder still commits/persists, and dragging a new column/metric in from the Datasource panel is unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
