rusackas commented on PR #40495: URL: https://github.com/apache/superset/pull/40495#issuecomment-4910117041
Thanks @Abdulrehman-PIAIC80387. The chart path here is the real fix... `get_query_str()` output is never pre-mutated, so running it through `mutate_sql_based_on_config` once is exactly right. The thing I want to check before we merge: on the SQL Lab non-CTA path, the SQL coming in is `executed_sql`, which already went through the mutator back at execution time (`sql_lab.py:532`). So a plain SELECT export would mutate twice. Harmless for an idempotent mutator or the default no-op, but if someone's mutator appends a per-call tag or comment it'd get doubled. Could you confirm that path, or move the mutation to the chart command's side where the SQL is still raw? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
