Abdulrehman-PIAIC80387 commented on PR #40495: URL: https://github.com/apache/superset/pull/40495#issuecomment-4912072400
Thanks @rusackas — moved the mutation to the chart command where the SQL is still raw. Shared base doesn't touch SQL anymore, and SQL Lab's path is untouched so `executed_sql` (already mutated at execution time) passes through unchanged. Added a regression test asserting SQL Lab doesn't call the mutator. Any further review welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
