rusackas commented on PR #36408:
URL: https://github.com/apache/superset/pull/36408#issuecomment-4910194331
Correcting myself here... I said earlier to just fix the commas, but looking
at the theme code the commas are only half of it. The bigger issue is the
nesting: this moves
`echartsOptionsOverrides`/`echartsOptionsOverridesByChartType` inside `token`,
but `Theme.tsx` pulls those off the top-level config, not out of `token`
(`const { echartsOptionsOverrides, ... } = config`). Nested inside `token` they
just get ignored, so the examples would silently not apply the overrides.
So they need to stay as top-level siblings of `token` (the original layout),
just with the formatting nits fixed. Since I offered to take this over anyway,
I'll rebase and straighten out the nesting when I do. Thanks for kicking it off
@chmelevskij!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
