rusackas commented on PR #35867: URL: https://github.com/apache/superset/pull/35867#issuecomment-4910212242
Circling back on my own rework here since it's gone quiet. Two of the things I flagged still stand, and since this one's on my plate now I'll just push them: - `optionSelector.reorder` still needs the bounds guard the sibling controls have... an out-of-range index splices `undefined` in, which blows up downstream. Trivial to add. - `DndFilterSelect` still only calls `setValues` on reorder, never `onChange`, so the filter order doesn't actually persist. One-liner to route `newValues` through `onChange`. The trickier one is the metric / `AdhocFilterControl` commit: the reorder shows correctly but `onDropLabel` closes over the pre-drag `values`, so the committed array is stale and a reload reverts the order. That needs the drop-commit to read the freshly reordered copy (a ref, or committing inside the reorder rather than on drop), so I'll sort that out and add a test pinning the committed order. Thanks again @CoderSxy for the original diagnosis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
