codeant-ai-for-open-source[bot] commented on code in PR #41497: URL: https://github.com/apache/superset/pull/41497#discussion_r3540835033
########## superset/mcp_service/theme/tool/get_theme_info.py: ########## @@ -0,0 +1,111 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Get theme info FastMCP tool + +This module contains the FastMCP tool for getting detailed information +about a specific theme by numeric ID or UUID. +""" + +import logging +from datetime import datetime, timezone + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.mcp_core import ModelGetInfoCore +from superset.mcp_service.theme.schemas import ( + GetThemeInfoRequest, + serialize_theme_object, + ThemeError, + ThemeInfo, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["discovery"], + class_permission_name="Theme", + annotations=ToolAnnotations( + title="Get theme info", + readOnlyHint=True, + destructiveHint=False, + ), +) +async def get_theme_info( + request: GetThemeInfoRequest, ctx: Context +) -> ThemeInfo | ThemeError: + """Get theme metadata by numeric ID or UUID. + + Returns theme details including name, system flags, and the antd + design-token configuration (json_data). + + The identifier may be a numeric ID or a UUID string. To find a theme + ID, use the list_themes tool first. + + Example usage: + ```json + { + "identifier": 1 + } + ``` + """ + await ctx.info( + "Retrieving theme information: identifier=%s" % (request.identifier,) + ) + + try: + from superset.daos.theme import ThemeDAO + + with event_logger.log_context(action="mcp.get_theme_info.lookup"): + get_tool = ModelGetInfoCore( + dao_class=ThemeDAO, + output_schema=ThemeInfo, + error_schema=ThemeError, + serializer=serialize_theme_object, + supports_slug=False, + logger=logger, + ) + + result = get_tool.run_tool(request.identifier) Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Do not require explicit type annotations for inferable local variables or module-level logger declarations in mcp_service modules; follow the existing repo convention when mypy already passes. **Applied to:** - `superset/mcp_service/**` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* ########## superset/mcp_service/theme/tool/list_themes.py: ########## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +List themes FastMCP tool + +This module contains the FastMCP tool for listing themes with filtering, +search, and pagination support. +""" + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.mcp_core import ModelListCore +from superset.mcp_service.theme.schemas import ( + ListThemesRequest, + serialize_theme_object, + ThemeError, + ThemeFilter, + ThemeInfo, + ThemeList, +) + +logger = logging.getLogger(__name__) + +DEFAULT_THEME_COLUMNS = [ + "id", + "theme_name", + "is_system_default", + "is_system_dark", +] +SORTABLE_THEME_COLUMNS = ["id", "theme_name", "changed_on", "created_on"] +ALL_THEME_COLUMNS = [ + "id", + "theme_name", + "json_data", + "uuid", + "is_system", + "is_system_default", + "is_system_dark", + "changed_on", + "changed_on_humanized", + "created_on", + "created_on_humanized", +] Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Do not require explicit type annotations for module-level constants in mcp_service; follow the existing repository convention where mypy infers these constants. **Applied to:** - `superset/mcp_service/**` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* ########## superset/mcp_service/theme/tool/__init__.py: ########## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from .create_theme import create_theme +from .get_theme_info import get_theme_info +from .list_themes import list_themes + +__all__ = [ + "create_theme", + "get_theme_info", + "list_themes", +] Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Do not flag unannotated module-level constants in mcp_service; mypy infers them and the repo convention is to leave these names unannotated. **Applied to:** - `superset/mcp_service/**` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* ########## superset/mcp_service/theme/tool/list_themes.py: ########## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +List themes FastMCP tool + +This module contains the FastMCP tool for listing themes with filtering, +search, and pagination support. +""" + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.mcp_core import ModelListCore +from superset.mcp_service.theme.schemas import ( + ListThemesRequest, + serialize_theme_object, + ThemeError, + ThemeFilter, + ThemeInfo, + ThemeList, +) + +logger = logging.getLogger(__name__) + +DEFAULT_THEME_COLUMNS = [ + "id", + "theme_name", + "is_system_default", + "is_system_dark", Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Do not flag unannotated module-level constant lists in mcp_service; mypy infers them and the repo convention is to keep them unannotated. **Applied to:** - `superset/mcp_service/**` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* ########## superset/mcp_service/theme/tool/list_themes.py: ########## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +List themes FastMCP tool + +This module contains the FastMCP tool for listing themes with filtering, +search, and pagination support. +""" + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.mcp_core import ModelListCore +from superset.mcp_service.theme.schemas import ( + ListThemesRequest, + serialize_theme_object, + ThemeError, + ThemeFilter, + ThemeInfo, + ThemeList, +) + +logger = logging.getLogger(__name__) + +DEFAULT_THEME_COLUMNS = [ + "id", + "theme_name", + "is_system_default", + "is_system_dark", +] +SORTABLE_THEME_COLUMNS = ["id", "theme_name", "changed_on", "created_on"] +ALL_THEME_COLUMNS = [ + "id", + "theme_name", + "json_data", + "uuid", + "is_system", + "is_system_default", + "is_system_dark", + "changed_on", + "changed_on_humanized", + "created_on", + "created_on_humanized", +] + +_DEFAULT_LIST_THEMES_REQUEST = ListThemesRequest() Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Do not flag unannotated module-level constants in mcp_service; mypy can infer these and the repo convention is to keep them unannotated. **Applied to:** - `superset/mcp_service/**` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
