gkneighb commented on PR #41497: URL: https://github.com/apache/superset/pull/41497#issuecomment-4911102584
Sorted — all 28 threads triaged and resolved. Applied: the RBAC-denied create_theme test (@aminghadersohi's ask, following the mutate-tool convention), blank-name validation mirroring the REST ThemePostSchema, LLM-context sanitization of the created name in the response (the create path was the one unsanitized echo), and type annotations on the new test functions/fixtures. Disputed with reasoning in-thread: the variable-annotation nits on `logger`/inferable locals/module constants, which no module in this codebase annotates and mypy doesn't require. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
