aminghadersohi commented on code in PR #41698:
URL: https://github.com/apache/superset/pull/41698#discussion_r3546784432
##########
superset/mcp_service/middleware.py:
##########
@@ -1451,6 +1457,7 @@ def create_response_size_guard_middleware() ->
ResponseSizeGuardMiddleware | Non
config.get("warn_threshold_pct", DEFAULT_WARN_THRESHOLD_PCT)
),
excluded_tools=config.get("excluded_tools"),
+ max_list_items=int(config.get("max_list_items",
DEFAULT_MAX_LIST_ITEMS)),
)
Review Comment:
Fixed in 76b6542 (via commit 9836b9c98). Added an explicit check: if
max_list_items is None: max_list_items = DEFAULT_MAX_LIST_ITEMS before the
int(...) cast, since dict.get(key, default) only falls back when the key is
missing, not when its value is explicitly None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
