bito-code-review[bot] commented on code in PR #41698:
URL: https://github.com/apache/superset/pull/41698#discussion_r3547792439
##########
tests/unit_tests/mcp_service/utils/test_token_utils.py:
##########
@@ -677,3 +677,43 @@ def test_progressive_truncation(self) -> None:
assert isinstance(result, dict)
assert result["id"] == 1 # Scalar fields preserved
assert len(notes) > 0
+
+ def test_large_dashboard_respects_default_max_list_items(self) -> None:
+ """Regression test for the Medialab large-dashboard report.
+
+ A dashboard with 463 charts and 48 native_filters should have
+ native_filters (48 items) left untouched under the new default cap
+ of 100, while charts (463 items) is truncated to 100 — a clear
+ improvement over the old flat 30-item cap, which truncated both.
+ """
+ response: dict[str, Any] = {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicate test response setup</b></div>
<div id="fix">
This test file contains duplicated setup code (7 lines) that appears at two
locations: lines 689-695 and 705-711. Consider extracting this into a shared
helper function or fixture to reduce duplication and improve maintainability.
</div>
</div>
<small><i>Code Review Run #07a087</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
