codeant-ai-for-open-source[bot] commented on code in PR #41897: URL: https://github.com/apache/superset/pull/41897#discussion_r3554794010
########## superset/subjects/api.py: ########## @@ -0,0 +1,123 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import logging + +from flask_appbuilder.models.sqla.interface import SQLAInterface + +from superset.constants import RouteMethod +from superset.subjects.filters import SubjectAllTextFilter +from superset.subjects.models import Subject +from superset.subjects.schemas import openapi_spec_methods_override +from superset.views.base_api import BaseSupersetModelRestApi + +logger = logging.getLogger(__name__) Review Comment: **Suggestion:** Add an explicit type annotation for the module-level logger variable. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The rule requires type hints for relevant variables that can be annotated. This module-level logger is newly introduced and is a typed variable candidate, but it is declared without an annotation, so the suggestion identifies a real violation. </details> <details> <summary><b>Rule source 📖 </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7a77f71d3a5840a689dde9216f1bf968&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7a77f71d3a5840a689dde9216f1bf968&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/subjects/api.py **Line:** 27:27 **Comment:** *Custom Rule: Add an explicit type annotation for the module-level logger variable. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41897&comment_hash=1ed15e7dc9737af16b581b0096c52c5aaed77c6bde7036f88c0a46270ebbf637&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41897&comment_hash=1ed15e7dc9737af16b581b0096c52c5aaed77c6bde7036f88c0a46270ebbf637&reaction=dislike'>👎</a> ########## superset/subjects/schemas.py: ########## @@ -16,6 +16,20 @@ # under the License. from marshmallow import fields, Schema +openapi_spec_methods_override = { + "get": {"get": {"summary": "Get a Subject"}}, + "get_list": { + "get": { + "summary": "Get a list of Subjects", + "description": "Gets a list of Subjects, use Rison or JSON " + "query parameters for filtering, sorting, " + "pagination and for selecting specific " + "columns and metadata.", + } + }, + "info": {"get": {"summary": "Get metadata information about this API resource"}}, +} Review Comment: **Suggestion:** Add an explicit type annotation to this new module-level mapping so the variable is type-hinted. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The new module-level mapping is a relevant variable that can be annotated, but it is introduced without any type hint. This matches the custom rule requiring Python type hints on new or modified code where applicable. </details> <details> <summary><b>Rule source 📖 </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=dd7af0ab43a8478c98ea4abd59cbc0ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=dd7af0ab43a8478c98ea4abd59cbc0ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/subjects/schemas.py **Line:** 19:31 **Comment:** *Custom Rule: Add an explicit type annotation to this new module-level mapping so the variable is type-hinted. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41897&comment_hash=738e1dc2e59b4034967e325a33fb73abe5ddb90082ef0efd3cd3257fdea02218&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41897&comment_hash=738e1dc2e59b4034967e325a33fb73abe5ddb90082ef0efd3cd3257fdea02218&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
