villebro commented on code in PR #41897:
URL: https://github.com/apache/superset/pull/41897#discussion_r3554837060
##########
superset-core/src/superset_core/common/models.py:
##########
@@ -285,6 +285,38 @@ class User(CoreModel):
active: bool
+class Role(CoreModel):
+ """
+ Abstract Role model interface.
+
+ Host implementations will replace this class during initialization
+ with concrete implementation providing actual functionality.
+ """
+
+ __abstract__ = True
+
+ # Type hints for expected attributes (no actual field definitions)
+ id: int
+ name: str | None
+
+
+class Group(CoreModel):
+ """
+ Abstract Group model interface.
+
+ Host implementations will replace this class during initialization
+ with concrete implementation providing actual functionality.
+ """
+
+ __abstract__ = True
+
+ # Type hints for expected attributes (no actual field definitions)
+ id: int
+ name: str | None
+ label: str | None
+ description: str | None
Review Comment:
Good idea for real new models, but this is a pre-existing model that's being
exposed as an abstract model in the core package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
