fnardin-maystreet commented on code in PR #32995:
URL: https://github.com/apache/superset/pull/32995#discussion_r3557853166
##########
superset-frontend/src/pages/DashboardList/index.tsx:
##########
@@ -469,15 +496,21 @@ function DashboardList(props: DashboardListProps) {
{canEdit && (
<Tooltip
id="edit-action-tooltip"
- title={t('Edit')}
+ title={
+ allowEdit
+ ? t('Edit')
+ : t(
+ 'You must be a dashboard owner in order to edit.
Please reach out to a dashboard owner to request modifications or edit access.',
+ )
+ }
placement="bottom"
>
<span
data-test="dashboard-row-edit"
role="button"
tabIndex={0}
- className="action-button"
- onClick={handleEdit}
+ className={`action-button ${allowEdit ? '' : 'disabled'}`}
+ onClick={allowEdit ? handleEdit : undefined}
Review Comment:
Actual bug. Updated ChartCard and DashboardCard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
