fnardin-maystreet commented on code in PR #32995:
URL: https://github.com/apache/superset/pull/32995#discussion_r3557921629
##########
superset-frontend/src/pages/DatasetList/index.tsx:
##########
@@ -880,27 +853,19 @@ const DatasetList: FunctionComponent<DatasetListProps> =
({
title={t('Edit')}
placement="bottom"
>
- <span
+ <IconButton
data-test="dataset-row-edit"
- role="button"
- tabIndex={0}
- className="action-button"
onClick={() => setSvCurrentlyEditing(original)}
- >
- <Icons.EditOutlined iconSize="l" />
- </span>
+ icon={<Icons.EditOutlined iconSize="l" />}
+ />
</Tooltip>
)}
Review Comment:
No longer relevant. Semantic view now gates the entire actions cell (both
edit and delete) on allowEdit in addition to canEdit/canDelete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
