Ujjwaljain16 commented on PR #37978:
URL: https://github.com/apache/superset/pull/37978#issuecomment-4935131635

   @EnxDev 
   @rusackas 
   thanks again for the thoughtful review!
   
   i took another pass over both the implementation and the tests
   rather than keeping a misleading test i have removed the keyboard regression 
test and the implementation detail click test
   i also cleaned up the remaining style nit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to