eschutho opened a new pull request, #41931:
URL: https://github.com/apache/superset/pull/41931
## Summary
The "Fixed viewport" popover control for deck.gl map charts
(`ViewportControl`) renders five numeric text inputs — longitude, latitude,
zoom, bearing, pitch — each with a visible `<FormLabel>` sibling, but never
passes a `label` prop down into the underlying `<TextControl>`. `TextControl`
only sets `aria-label={this.props.label}` on its `<Input>`, so with `label`
undefined, all five inputs render with no accessible name at all.
**WCAG 2.1 SC 4.1.2 (Name, Role, Value) — Level A.**
## What changed
Added `label={ctrl}` to each `<TextControl>` call in `renderTextControl`, so
the accessible name matches the visible label text ("longitude", "latitude",
"zoom", "bearing", "pitch") — the same `label` → `aria-label` passthrough
pattern already used correctly by the sibling `NumberControl` component.
Behavior is unchanged — this only adds an `aria-label` attribute to the DOM;
no visual or functional change.
## Test plan
- [ ] Open a deck.gl-based chart in Explore, open the "Fixed" viewport
control popover.
- [ ] Tab through the five inputs with a screen reader (e.g. VoiceOver/NVDA)
and confirm each announces its correct name ("longitude edit text", "latitude
edit text", etc.) instead of a generic/unlabeled announcement.
- [ ] Confirm the popover still renders and functions identically (values
still editable, onChange still fires) — no visual regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
