bito-code-review[bot] commented on code in PR #41907:
URL: https://github.com/apache/superset/pull/41907#discussion_r3560355178
##########
superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts:
##########
@@ -431,6 +431,7 @@ export default function transformProps(
groupby,
selectedValues,
onContextMenu,
+ onDrillDown,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test for onDrillDown</b></div>
<div id="fix">
Line 434 includes `onDrillDown` in the returned props but there is no
corresponding test in `test/Radar/transformProps.test.ts`. Compare Gauge
plugin: it has a passing test that verifies `onDrillDown` is correctly passed
through (test/Gauge/transformProps.test.ts:729-768). Add a test to prevent
regression.
</div>
</div>
<small><i>Code Review Run #3f0632</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/transformProps.ts:
##########
@@ -256,7 +256,7 @@ export default function transformProps(
};
}, {});
- const { setDataMask = () => {}, onContextMenu } = hooks;
+ const { setDataMask = () => {}, onContextMenu, onDrillDown } = hooks;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test coverage for onDrillDown</b></div>
<div id="fix">
The `onDrillDown` pass-through and click wiring lack test coverage in
`test/Pie/transformProps.test.ts`. Funnel (lines 86–128 of
`test/Funnel/transformProps.test.ts`) already has two tests for this behavior.
Without equivalent Pie tests, the drill-down path for Pie is unverified and may
silently regress. This is a divergence from the established pattern for
drill-down charts.
</div>
</div>
<small><i>Code Review Run #3f0632</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
