rusackas commented on PR #41907: URL: https://github.com/apache/superset/pull/41907#issuecomment-4971994098
I added a hold label to this PR because I believe it's a significant enough change to require a SIP. I think we want to look at the need for an additional drilling method since we already have Drill By that allows a lot of flexibility. So to switch to something hierarchical that require configuration should get some level of consensus. I think we'd want to see the UI in screenshots of how the drilling works. I think we'd want to hear the use cases of why we need a new drilling method or what's insufficient about the existing one, and I think we'll need more detail on how one sets up the hierarchy for hierarchical drilling, especially in terms of semantic layer extensions that are now landing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
