rusackas commented on PR #32995: URL: https://github.com/apache/superset/pull/32995#issuecomment-4938600988
Thanks for coming back to this and knocking out the earlier notes — EditableTitle's out, the editors check is DRY'd up into `isUserInEditors`, and the card views are gated now. Nice progress. Looks like the latest push went red, though. There's a type error in `DashboardList/index.tsx` (TS2322, around line 772), and the new card/table gating broke a batch of existing tests — `ChartList.cardview`, `DashboardList`, plus the `ChartTable`/`DashboardTable` home widgets. Worth getting CI green before another pass. A couple of unrelated bits are still hanging around too — the SliceHeader max-width bump and the blank line in DashboardWrapper. Left suggestions to revert both. Thanks for sticking with this one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
