fnardin-maystreet commented on code in PR #32995:
URL: https://github.com/apache/superset/pull/32995#discussion_r3558065165
##########
superset-frontend/src/features/charts/ChartCard.tsx:
##########
@@ -67,35 +69,49 @@ export default function ChartCard({
saveFavoriteStatus,
favoriteStatus,
chartFilter,
- userId,
+ user,
handleBulkChartExport,
getData,
}: ChartCardProps) {
+ const userId = user?.userId;
+
const history = useHistory();
const canEdit = hasPerm('can_write');
const canDelete = hasPerm('can_write');
const canExport = hasPerm('can_export');
+ const allowEdit = isUserEditorOrAdmin(user, chart.editors);
Review Comment:
Same as above. The mismatch is carried forward by ChartListProps and
DashboardListProps which would also benefit from a stronger typing. Outside of
the scope of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
