bito-code-review[bot] commented on code in PR #41917:
URL: https://github.com/apache/superset/pull/41917#discussion_r3563925956
##########
superset/db_engine_specs/snowflake.py:
##########
@@ -265,12 +265,13 @@ def get_catalog_names(
In Snowflake, a catalog is called a "database".
"""
- return {
- catalog
- for (catalog,) in inspector.bind.execute(
- text("SELECT DATABASE_NAME from information_schema.databases")
- )
- }
+ with inspector.bind.connect() as conn:
Review Comment:
<!-- Bito Reply -->
The suggestion to use `inspector.engine.connect()` instead of
`inspector.bind.connect()` is correct. The `Inspector` class in SQLAlchemy does
not have a `bind` attribute, and using `engine` is the standard approach for
accessing the connection, as seen in other engine specifications.
**superset/db_engine_specs/snowflake.py**
```
with inspector.engine.connect() as conn:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
