hy144328 commented on code in PR #41917:
URL: https://github.com/apache/superset/pull/41917#discussion_r3563953921
##########
tests/integration_tests/datasets/commands_tests.py:
##########
@@ -279,8 +279,9 @@ def test_export_dataset_command_unicode_chars(self, mock_g)
-> None:
mock_g.user = security_manager.find_user("admin")
examples_db = get_example_database()
with examples_db.get_sqla_engine() as engine:
- engine.execute("DROP TABLE IF EXISTS 中文")
- engine.execute("CREATE TABLE 中文 AS SELECT 2 as col")
+ with engine.begin() as conn:
+ conn.execute("DROP TABLE IF EXISTS 中文")
+ conn.execute("CREATE TABLE 中文 AS SELECT 2 as col")
Review Comment:
Done.
##########
tests/integration_tests/datasets/commands_tests.py:
##########
@@ -307,7 +308,8 @@ def test_export_dataset_command_unicode_chars(self, mock_g)
-> None:
db.session.delete(example_dataset)
db.session.commit()
with examples_db.get_sqla_engine() as engine:
- engine.execute("DROP TABLE 中文")
+ with engine.begin() as conn:
+ conn.execute("DROP TABLE 中文")
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
