etr2460 commented on a change in pull request #8389: Allow fetching all rows
from results endpoint
URL:
https://github.com/apache/incubator-superset/pull/8389#discussion_r337623069
##########
File path: superset/views/utils.py
##########
@@ -176,7 +176,9 @@ def get_datasource_info(
return datasource_id, datasource_type
-def apply_display_max_row_limit(sql_results: Dict[str, Any]) -> Dict[str, Any]:
+def apply_display_max_row_limit(
+ sql_results: Dict[str, Any], rows: Optional[int] = None
Review comment:
Async vs sync queries are dependent on the config of the datasource right?
Which is something the user doesn't have any control over unless they're admin.
I guess if you're calling this with an API, then you can decide if you want to
make an async or async query yourself though.
I think it's fine, but it's just another little wart with superset that we
need to remember
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
