etr2460 commented on a change in pull request #8389: Allow fetching all rows
from results endpoint
URL:
https://github.com/apache/incubator-superset/pull/8389#discussion_r337636690
##########
File path: superset/views/core.py
##########
@@ -2459,8 +2459,9 @@ def cache_key_exist(self, key):
@has_access_api
@expose("/results/<key>/")
+ @expose("/results/<key>/<int:rows>")
Review comment:
it seems a little weird to encode the limit in the url like this. I think it
would be preferable to construct the url like: `/results/key?rows=1000`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
