codeant-ai-for-open-source[bot] commented on code in PR #36856:
URL: https://github.com/apache/superset/pull/36856#discussion_r3565313678
##########
superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx:
##########
@@ -498,7 +498,7 @@ const ExtraOptions = ({
onChange={onInputChange}
>
{t(
- 'Impersonate logged in user (Presto, Trino, Drill, Hive,
and Google Sheets)',
+ 'Impersonate logged in user (Presto, Trino, Drill, Hive,
Snowflake and Google Sheets)',
Review Comment:
**Suggestion:** The newly expanded label now advertises Snowflake and Google
Sheets, but the adjacent help text still only explains Presto/Trino/Hive
behavior, which creates a user-facing documentation mismatch and can cause
incorrect configuration for the newly listed engines; update the tooltip copy
to include the Snowflake/Google Sheets semantics. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Minor ๐งน</summary>
```mdx
- โ ๏ธ Database connection modal misleads Snowflake impersonation
configuration.
- โ ๏ธ Google Sheets impersonation behavior undocumented in tooltip text.
```
</details>
<details>
<summary><b>Steps of Reproduction โ
</b></summary>
```mdx
1. Open the Database connection modal in the UI and navigate to the
"Security" section
rendered by `ExtraOptions` in
`superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx:13-21`
(see hunk
around lines 450-569).
2. Observe the impersonation checkbox defined at lines 45-53 of the snippet:
the label
uses `t('Impersonate logged in user (Presto, Trino, Drill, Hive, Snowflake
and Google
Sheets)')`, advertising Snowflake and Google Sheets support.
3. Hover over the adjacent `InfoTooltip` at lines 55-62, whose tooltip text
only describes
Presto, Trino, and Hive behavior: it explains execution as the logged-in
user for
Presto/Trino and Hive-specific
`hive.server2.enable.doAs`/`hive.server2.proxy.user`
semantics, without mentioning Snowflake or Google Sheets.
4. This creates a user-facing documentation mismatch: the checkbox label
promises behavior
for Snowflake/Google Sheets added in this PR, but the explanatory text
remains limited to
Presto/Trino/Hive, which can mislead users about how impersonation actually
works for the
newly listed engines.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c1c8480578ec47f289cc820fe43f36c9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c1c8480578ec47f289cc820fe43f36c9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx
**Line:** 501:501
**Comment:**
*Comment Mismatch: The newly expanded label now advertises Snowflake
and Google Sheets, but the adjacent help text still only explains
Presto/Trino/Hive behavior, which creates a user-facing documentation mismatch
and can cause incorrect configuration for the newly listed engines; update the
tooltip copy to include the Snowflake/Google Sheets semantics.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F36856&comment_hash=722e4687fcaf7f768b930649af5b257f183ad2d737e81f174e1b018f7d7ddf25&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F36856&comment_hash=722e4687fcaf7f768b930649af5b257f183ad2d737e81f174e1b018f7d7ddf25&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
