rusackas commented on code in PR #36856:
URL: https://github.com/apache/superset/pull/36856#discussion_r3565326090
##########
superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx:
##########
@@ -498,7 +498,7 @@ const ExtraOptions = ({
onChange={onInputChange}
>
{t(
- 'Impersonate logged in user (Presto, Trino, Drill, Hive,
and Google Sheets)',
+ 'Impersonate logged in user (Presto, Trino, Drill, Hive,
Snowflake and Google Sheets)',
Review Comment:
Confirmed and applied (b45276bfd8) — added a Snowflake/Google Sheets
sentence to the tooltip (both impersonate via the user's own OAuth credentials
rather than a shared service account, per
`SnowflakeEngineSpec.impersonate_user`/`GSheetsEngineSpec.impersonate_user`),
so the label and the explanatory copy stay in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
