gkneighb commented on code in PR #41860:
URL: https://github.com/apache/superset/pull/41860#discussion_r3565573524
##########
superset/mcp_service/app.py:
##########
@@ -384,6 +384,11 @@ def get_default_instructions(
Requires handlebars_template with Handlebars HTML template string.
Supports query_mode="aggregate" (with metrics/groupby) or "raw" (with
columns).
Data available as {{{{data}}}} array; helpers: dateFormat, formatNumber,
stringify.
+- chart_type="histogram": Histogram of a numeric column's distribution
+ (column required; optional bins, groupby, normalize, cumulative)
+- chart_type="box_plot": Box plot comparing statistical spread
+ (metrics + distribute_across required; optional dimensions,
+ whisker_type: tukey | min_max | percentile)
Review Comment:
Confirmed and fixed in a375284697 — both remaining 7-type passages (server
instructions and the get_chart_type_schema docstring) now list all 9 types.
##########
superset/mcp_service/chart/tool/get_chart_type_schema.py:
##########
@@ -48,6 +50,8 @@
"mixed_timeseries": TypeAdapter(MixedTimeseriesChartConfig),
"handlebars": TypeAdapter(HandlebarsChartConfig),
"big_number": TypeAdapter(BigNumberChartConfig),
+ "histogram": TypeAdapter(HistogramChartConfig),
+ "box_plot": TypeAdapter(BoxPlotChartConfig),
Review Comment:
Confirmed and fixed in a375284697 — both remaining 7-type passages (server
instructions and the get_chart_type_schema docstring) now list all 9 types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
